Lu shangs quest crash

[joshr45]

Trading moat carp to Joulet crashes the server, im sure it happens with Gallijaux as well since its the same code with the quest changed.

[The_Kuti]

If a missing ";" can crash the server then thats the problem.

Code: Select all

(...)
	 count = trade:getItemCount();
	 MoatCarp = trade:getItemQty(4401)
	 ForestCarp = trade:getItemQty(4289)
	 fishCountVar = player:getVar("theCompetitionFishCountVar");
	 (...)

There are two missing ";"-s.

EDIT: same applies to the other NPC.

[kjLotus]

iirc lua doesn't require semicolons

[Metalfiiish]

To me this seems like a possible culprit:

Code: Select all

totalFish = MoatCarp + ForestCarp + fishCountVar
player:setVar("theCompetitionFishCountVar",totalfish);

Should be:

Code: Select all

totalFish = MoatCarp + ForestCarp + fishCountVar
player:setVar("theCompetitionFishCountVar",totalFish);

totalfish is undefined, however totalFish is defined.

Second issue:

Code: Select all

function onTrigger(player,npc)
        if(player:getQuestStatus(SANDORIA,THE_COMPETITION) == QUEST_AVAILABLE

Should be the rivalry for that npc, if you look closely the onTrade is looking for the proper quest, however the quest starting CS is looking for the opposite quest.

Code: Select all

function onTrigger(player,npc)
        if(player:getQuestStatus(SANDORIA,THE_RIVALRY) == QUEST_AVAILABLE

Would test/commit fix but stuck at work.

[PrBlahBlahtson]

http://code.google.com/p/onetimexi/source/detail?r=2997