Page 1 of 2
MeritSystem: Causing game server crash.
Posted: Tue Apr 22, 2014 8:38 am
by tagban
https://github.com/DarkstarProject/darkstar/issues/159
Wasn't sure whats going on, seems like the merits when turned in are causing it? And its not for everyone. Might just need a debug check at this point, to check to see if something is wrong, return it? that way it doesn't crash.
Re: MeritSystem: Causing game server crash.
Posted: Tue Apr 22, 2014 1:41 pm
by kjLotus
it's because someone is trying to log in, and their charID is 0 (from the login packet)
Re: MeritSystem: Causing game server crash.
Posted: Tue Apr 22, 2014 8:07 pm
by tagban
So the login server isn't pushing the correct info? It always seems to crash on the Merit Thingy..
Re: MeritSystem: Causing game server crash.
Posted: Tue Apr 22, 2014 8:11 pm
by atom0s
Its an issue with the lobby < > client communication. The exact reason/location is not known at the moment though. Basically the first packet the game client sends to the game server is a login packet (0x0A) which contains your charid that is logging in. DSP has no protection or checks to ensure that the charid is valid.
Re: MeritSystem: Causing game server crash.
Posted: Tue Apr 22, 2014 8:12 pm
by tagban
So its a random crash, so no point in me running debug mode anymore?
Re: MeritSystem: Causing game server crash.
Posted: Tue Apr 22, 2014 8:47 pm
by kjLotus
tagban wrote:So its a random crash, so no point in me running debug mode anymore?
i'm just gonna check against charid 0 and be done with it
Re: MeritSystem: Causing game server crash.
Posted: Tue Apr 22, 2014 8:56 pm
by tagban
Had another crash, but not sure if its related or not... So didn't want to make a new bug yet.
http://ffxi.bnet.cc/dumps/DSGame-server-4-22-2.7z
Re: MeritSystem: Causing game server crash.
Posted: Tue Apr 22, 2014 9:04 pm
by kjLotus
it's the same one you posted before the charID one.. thought i fixed it :\
Re: MeritSystem: Causing game server crash.
Posted: Tue Apr 22, 2014 9:07 pm
by tagban
Yea I update my scripts (or have it pull and re-build) after every crash just to be on the safe side.. lol I thought you had to.
Re: MeritSystem: Causing game server crash.
Posted: Tue Apr 22, 2014 9:09 pm
by kjLotus
tagban wrote:Yea I update my scripts (or have it pull and re-build) after every crash just to be on the safe side.. lol I thought you had to.
ah... it's a GM doing that. if a real character crashes the server, i'll be glad to fix it, but GMs have tons of ways to break the server so i'm not gonna bother trying to figure out what he did
tell kaisho to stop doing stupid things