Locking Quested Weaponskills to be unlocked with WS points

[bluesolarflare]

As the title states, looking for a way to lock the Quested WS's so players have to unlock them with the appropriate quest. As it stands now players automatically learn the Quested WS's (Evisceration, Savage Blade, etc) if they have the correct skill. I know there is a way to remove it by changing the skill level but I would like players to be able to unlock it. Is this possible?

[whasf]

Is this possible?

Yes.

[bluesolarflare]

What is the best way to implement this as it seems this feature is missing.

[whasf]

What is the best way to implement this as it seems this feature is missing.

Write the quests, test them, remove the code that automatically gives the weapon skills to the character (I don't know if it's in the core or database), then put it in a pull request to the project.

[kjLotus]

there's currently nothing to determine if you know a weaponskill or not other than skill level or a modifier currently, so it'll be up to you to figure out how to do that (i haven't really thought of it myself, as it's not really a big priority and I hated those quests anyways)

[TeoTwawki]

Worth noting the modifier currently only supports 1 ws at a time, as it was intended solely for ws from weapons making it a poor choice to implement quested ws. I don't statically checking the quest status = completed would be a good idea..aside from being icky code there are too many quests, so we'd probably want to make a new method for storing and retrieving which ones you've learned.

(Was created to support Dynamis relics, and I dunno wtf happens if you have relic bow+relic KG at same time..Hopefully the modifier is being checked on the item not the player but I have not looked).

[bluesolarflare]

If I recall the add_weaponskill mod is tied to the weapon itself. The only thing I can think of off the top of my head is what you mentioned where if you learn the ws it is stored and bound to the player and there would have to be a special case to add a weaponskill under certain circumstances similar to how spells are learned ( i.e. addspell).

After much thought I decided to forgo with the retail method on my server since it cannot be done and simply allow players to have access to these Weaponskills naturally but in a weakened state and players have to do a quest to fully unlock their power.