My port of the project many things.

bluekirby0
Developer
Posts: 707
Joined: Sun Jul 22, 2012 12:11 am

Re: My port of the project many things.

Post by bluekirby0 » Mon Jun 10, 2013 9:54 pm

The bigger this gets, the less likely it'll ever get reviewed. Small patches are infinitely better, especially since it is easier to pinpoint bugs down to specific ones.

compmike19
Posts: 115
Joined: Wed Jan 23, 2013 11:14 pm

Re: My port of the project many things.

Post by compmike19 » Wed Jun 12, 2013 11:42 pm

Updated r3510

New:

Traits - only had a cursory testing let me know if anyone finds errors.
Conserve MP - I could not find code for it anywhere except the modifier, should work now.
Conserve TP
Blood Boon
Divine Benison
Tranquil Heart
Dead Aim

Associated item mods filled in, corrected some Conserve TP that were in as Store TP in item_mods.
Attachments
Compmikes r3510.patch
(13.28 MiB) Downloaded 224 times

compmike19
Posts: 115
Joined: Wed Jan 23, 2013 11:14 pm

Re: My port of the project many things.

Post by compmike19 » Sat Jun 15, 2013 4:15 am

Updated r3520

New:

Spells Added
Klimaform
Animus Augeo
Animus Minuo
Adloquium

Gave bar spells the MDB for having Afflatus Solace in effect with Orison Bliaud +1 / +2.

Fixed Tranquility and Equanimity to not activate on a char with Pax status.

Fixed Mug for bonuses with Assassin's Bonnet +1 / +2.

Added Nether Void bonus for Bale Flanchard +1 / +2.

A little maintenance done on item_mods.

Reorganized item_armor in numerical order.

Uploaded the whole patch in the 7 zip file. Also have the individual patches up for SQL, source, or luas.
Attachments
Compmikes r3520 Whole.7z
(994.61 KiB) Downloaded 210 times
Compmikes r3520 SQL.patch
(8.38 MiB) Downloaded 213 times
Compmikes r3520 SCR.patch
(809.64 KiB) Downloaded 198 times
Compmikes r3520 LUA.patch
(1.85 MiB) Downloaded 202 times

compmike19
Posts: 115
Joined: Wed Jan 23, 2013 11:14 pm

Re: My port of the project many things.

Post by compmike19 » Wed Jun 19, 2013 11:41 am

Updated r3556

New:
LUA for 2 foods - Mog Pudding and Sakura Biscuit
Ancient, Arcane, Holy and Warding Circles give their damage reduction against their mobs and the players attack increase towards them, the effect is less on subjobs, durations corrected, only 1 circle can be active at a time, and items that modify them are accounted for.
Quadruple attack chance in assassins charge effect.

Moved Bunch of Gysal Greens and Pamamas item effects to get powers in equipment like rice balls.

Changed the copyright date on Darkstar to 2010-2013.

A few other minor changes I forget, wanted to get another patch out since so many updates have rolled out.

Remember Character SQL table changes so make sure you always backup and manually adjust them.

In the zip are the whole patch, and separate patches for only sql, source, and lua.
Attachments
Compmikes r3556 Patch.7z
(1.12 MiB) Downloaded 225 times

compmike19
Posts: 115
Joined: Wed Jan 23, 2013 11:14 pm

Re: My port of the project many things.

Post by compmike19 » Sat Jul 06, 2013 5:26 am

Updated r3639

New:
About 60-70 food item luas.

Put the step accuracy mods for items in item_mods.sql

Added in Gedads mobskills in the SQL.

Fixed an NPC error in my SQLs for LaLoff Amphitheater. Moved all my other spell variables to local.
Attachments
Compmikes r3639 Patch.7z
(1.31 MiB) Downloaded 193 times

compmike19
Posts: 115
Joined: Wed Jan 23, 2013 11:14 pm

Re: My port of the project many things.

Post by compmike19 » Tue Jul 16, 2013 4:48 am

Updated r3732

New:

Added in all the items from the 7-12-13 update. item_armor needs the model ids filled in.
item_basic item_armor item_mods item_latents item_weapons items_usable done

Updated teleports for chocobo masque +1 to function.
Lua for rustic / shoal maillot +1, chocobo masque +1, and korrigan beret.
Added a few more missing key items.
Corrected player.lua to include the new maps on the ALL_MAPS setting.

Fix:
Corrected a few job masks in item_armor.
Attachments
Compmikes r3732 Patch.7z
(1.65 MiB) Downloaded 212 times

lautan
Developer
Posts: 164
Joined: Mon Jul 30, 2012 6:17 pm

Re: My port of the project many things.

Post by lautan » Tue Jul 16, 2013 3:30 pm

Anyone committing this stuff? At least the simple stuff like food.

User avatar
kjLotus
Special Guest
Posts: 1813
Joined: Sun Jul 22, 2012 2:16 pm

Re: My port of the project many things.

Post by kjLotus » Tue Jul 16, 2013 3:49 pm

lautan wrote:Anyone committing this stuff? At least the simple stuff like food.
kjLotus wrote:check out another copy of the repository, and transfer over your stuff one at a time and make a .patch. (ie: copy and paste relevant section of code to one or two related things), and then make a .patch for it, and then revert it, keeping the files trunk but with a .patch for what you did. and then, do that a bunch of times to have a ton of different .patches (seriously, the smaller they are, the faster this will go). so for example, have a .patch for merit abilities. have another .patch for food items. and another one for spells. and another one for new JAs. etc...

bluekirby0
Developer
Posts: 707
Joined: Sun Jul 22, 2012 12:11 am

Re: My port of the project many things.

Post by bluekirby0 » Tue Jul 16, 2013 11:27 pm

bluekirby0 wrote:The bigger this gets, the less likely it'll ever get reviewed. Small patches are infinitely better, especially since it is easier to pinpoint bugs down to specific ones.
Thus far our recommendations have been ignored. Nobody wants to sift through this much code to find out if any of it even works. Everyone who has used these patches has complained about how buggy they are. Its like he doesn't even want to cooperate, instead just making his own buggy branch of the project in the form of patches. This is exactly how open-source software is NOT supposed to work.

lautan
Developer
Posts: 164
Joined: Mon Jul 30, 2012 6:17 pm

Re: My port of the project many things.

Post by lautan » Wed Jul 17, 2013 8:55 am

I agree. I asked for a patch with just foods and he sent it to me. I'll be looking at it today.

Post Reply