Deprecated Darkstar fourms

Here's my contributions, I've been working on a lot.

Included are works from off this board that are not in trunk also. A few notable ones are most of the additional stuff from Racsr's port http://forums.dspt.info/viewtopic.php?f=20&t=615. All of Gedad's mob and npc spawns and the latest from mvd1987.

Almost all the C++ comments are translated to english, you will have to be careful checking over file when updating.

A lot of abilities and effects have been enhanced for equipment bonuses, they will probably get moved to mods in modifier.h later, but it's a lot of work to redo at the moment.

Abilities modified / working:
Aggressor, Berserk, Warcry
Dancer Jigs, Dancer Waltzs
Convert
Cover, Rampart, Sentinel
Reward
Scavenge

Effects modified / working:
Addle
All Bard song effects including unimplemented in retail (Cactaur Fugue, Protected Aria etc ..)
Counterstance
Curse I
Death
Defense Down - modded for piercing resistance of undead on Banish
Dia
Embrava
Ifirit's Favor
Kaustra
Last Resort
Seigan

Magic:
All Bard Songs are implemented except Sentinel's Scherzo I and work with duration enhancement gear.
Bard Song durations mods implemented in core for songs thru SingSong
All merited magics work.
Relevant magics modded for Estoqueurs duration gear.
Enspell enhancement gear accounted for.
All magic burst bonus dmg equip accounted for.
Estoquers Sayon +2 enfeebling bonus accounted for.
Every spell has a lua even spells you can't usually get and should work except the ones the client blocks you from casting (ie Dia IV, Poisonga II) even they have luas. Exception new Geomancer spells and absorb-attri.
Banish spells use damage type resistance down on undead.
All spells modded for equipment bonuses.
Spell_list.sql is complete - I have jobs set for the normally unusable magics please ignore or modify as you see fit.

Statuses has more complete list.

A few Weaponskills modified or created.

BCNMs in numerical order.

Items:
Items_basic should be about 98% complete including new update items and have AH categories correct so they get listed on your AH with AH Tool. A lot of the new items need base sell price corrected.

Items_usable should be about 98% complete including new update items. A lot need animations.
Items_furniture included a few missing.

Items_mods and items_latents include almost all armor done with the exception of the new update items, body 86-75, and hands 99-75. Unimplemented mods are commented out for easy later fixing.
New modifiers included for casting time and recast times.

Added extra gear mods to harvesting, mining, logging luas.

Added quite a few item luas, new and modified ones for gear enhancements. All of the teleport items work correctly.

Traits are filled out better and go to lvl 99, unimplemented ones commented out for later fix as modifiers are created.

Abilities.h more complete list.

Added most of the additional weapon effects in core. Exception any weapon that needs ammo slot requirement (battery, wind fan, etc ..)

Merits working:
WHM
MERIT_BAR_SPELL_EFFECT
MERIT_BANISH_EFFECT
MERIT_REGEN_EFFECT
MERIT_PROTECTRA_V
MERIT_SHELLRA_V
BLM
MERIT_FIRE_MAGIC_POTENCY
MERIT_ICE_MAGIC_POTENCY
MERIT_WIND_MAGIC_POTENCY
MERIT_EARTH_MAGIC_POTENCY
MERIT_LIGHTNING_MAGIC_POTENCY
MERIT_WATER_MAGIC_POTENCY
MERIT_FLARE_II
MERIT_FREEZE_II
MERIT_TORNADO_II
MERIT_QUAKE_II
MERIT_BURST_II
MERIT_FLOOD_II
RDM
MERIT_FIRE_MAGIC_ACCURACY
MERIT_ICE_MAGIC_ACCURACY
MERIT_WIND_MAGIC_ACCURACY
MERIT_EARTH_MAGIC_ACCURACY
MERIT_LIGHTNING_MAGIC_ACCURACY
MERIT_WATER_MAGIC_ACCURACY
MERIT_DIA_III
MERIT_SLOW_II
MERIT_PARALYZE_II
MERIT_PHALANX_II
MERIT_BIO_III
MERIT_BLIND_II
PLD
MERIT_COVER_EFFECT_LENTH
MERIT_GUARDIAN
BRD
MERIT_LULLABY_RECAST
MERIT_FINALE_RECAST
MERIT_MINNE_EFFECT
MERIT_MINUET_EFFECT
MERIT_MADRIGAL_EFFECT
MERIT_NIGHTINGALE
MERIT_TROUBADOUR
MERIT_FOE_SIRVENTE
MERIT_ADVENTURERS_DIRGE
NIN
MERIT_KATON_EFFECT
MERIT_HYOTON_EFFECT
MERIT_HUTON_EFFECT
MERIT_DOTON_EFFECT
MERIT_RAITON_EFFECT
MERIT_SUITON_EFFECT
MERIT_KATON_SAN
MERIT_HYOTON_SAN
MERIT_HUTON_SAN
MERIT_DOTON_SAN
MERIT_RAITON_SAN
MERIT_SUITON_SAN
WAR
MERIT_AGGRESSIVE_AIM

thanks, i'll take some of this later when we start adding in contributions again

oke nice work compmike,

i will check your work and will add my weapons to it once they are fully done,

i need the additional mods also so i can see what i can do about that and will update it on your patch oke, so tjhey have a full package's when they take on contributions again,

and i think its bether to spilt up your patches so its easyer to check them, but i can sort it out myself also.

will let you know when all weapons are done oke, most models and jobs are changed like thewy should, but since the new jobs re in some will need to change again,

mostly the specail weapons need there mods in and i miss a few normal weapons above 75 but im sorting that out all now,

like i said before i first wnat everything to be checked first before i give it out

greetings michael

Take II

Added about 374 item luas. A bunch are the temporary items. A bunch are missing foods. Group foods are in but not with the group effect. The rest are enchantment items and a few misc potions etc.

Added Quadruple Attack to battleutils.cpp

The weapons that let you eat raw foods are implemented.

Effects
Enhanced the BAR Element effects for Beneficus
Implemented the NEGATE_XXX effects

A lot of the modifiers got added to clean up the item_mods sql spell luas and magic lua (still need to do Bard Song mods it's a mess in their luas)

Modifiers Added
MOD_MAG_BURST_DMG
MOD_ELEM_MAG_DMG
MOD_ENFB_MAG_DMG
MOD_NIN_MAG_DMG
MOD_DEATHRES
MOD_TERRORRES
MOD_AMNESIARES
MOD_DOOMRES
MOD_JIG_TIME
MOD_ENSPELL_DURATION
MOD_CHOCOBO_TIME
MOD_EAT_RAW_FISH
MOD_EAT_RAW_MEAT
MOD_QUADRUPLE_ATTACK
MOD_SNEAK_DUR
MOD_INVIS_DUR
MOD_ENHANCING_DUR
MOD_BARSPELL_DUR
MOD_BARSPELL_PWR
MOD_DRAIN_ASPIR
MOD_CURSNA_EFFECT
MOD_CURSNA_RCVD
MOD_STONESKIN_HP

Item Mods should be all updated for the new modifiers and a few fixes, had to change the # on MOD_CHARM_CHANCE

Since the hairpinning is still broken I really don't have anyone to test, I've tested some but not everything, please let me know if something is broken, drop me an email or msg me on IRC.

Forgot to include the new lua function getSkillType in lua_spell.cpp so magics using the new modifiers didn't work correctly, fixed now sorry. Also updated to current revision and I finished all the body armors. Now just Hand armor and the new armors from SoA then to ammo and weapons for mods.

RDM and BLM merits working? Sheeeeet that's awesome man! Wanna take a whack at Konzen-Ittai and the remaining SAM merits for me haha

R3277 Updated

All armor should be finished until new modifiers are made. Going to start working on weapons now. I added in the rest of the additional effects but they need more testing. Todo remove batteries, fans, hydro pumps on the weapons that use them. I think the Death effect on those 2 weapons might be a problem, but not for sure. Also need to add immunities for some effects to mobs.

Take III R3296

All weapons should be in now, all non functional mods commented out for later fixes. I switched some of the ability lua mods to latenet effects where they should have been before I played with them.

Sublimation works for Scolar now.

Bard instruments went to modifiers to clean up those luas battleutils and magic lua. 22 New modifiers for Bard songs and effects.

Mob Spawn points has all Gedads newest points into it and has been reorganized in mostly numerical order to easily see where numbers are missing.

Traits also got a bump for the missing Rune Fencer traits.

Found like 2 more missing additional effects for weapons I missed Cocytus Pole and another.

I will continue to work on cleaning up Item mods sql the fix the non existant mods and some missing abilities.

Please let me know if you find a mistake. Thanks!

oke nice work compmike,


did you check all 75+ weapons i sended you?? most high level missed some core mods but the rest worked, i added the models and weapon lines in myself so it should work fine,

let me know if some act strange and i need to change them,

its really speeding up now we all work togheter

Updated R3300

Added in Skill Mods to Core
Convert x% of Damage taken to MP
Convert % of Damage to MP upon successful block
Convert x% of Physical Damage to TP

Lua Mods
Convert Cure amount to MP
Convert x% of Magic Elemental Damage to MP

New Modifiers
MOD_WS_DMG - % of all WS Damage
MOD_CRIT_DMG - % increase to Crit Hit Damage
MOD_SNEAK_ATK_DMG - Base Dex percentage Modifier

Starlight WS takes Dukka for 3x Potency in account

Increase Critical Hit Damage Trait now working.

Added in all Gedads new mob spawns except Abyssea Attowah

Added in Mvd1987's Weapon and Armor Model and Job Mask info.

Updated r3304 - Rest of Gedads Abyssea spawns in

Made a mistake with Vajra, fixed now.

Added all throwing weapon additional effects (Discus and Boomerangs)

The new modifiers should fix a lot of traits that were nonfunctional.

New Modifiers
MOD_TRICK_ATK_MOD
MOD_SATA_DMG
MOD_GILFINDER
MOD_SHIELD_MASTERY
MOD_SHIELD_DEF
MOD_TACTICAL_GUARD
MOD_TACTICAL_PARRY
MOD_OCCULT_ACCUMEN
MOD_STALWART_SOUL
MOD_BARRAGE
MOD_SHADOWBIND
MOD_GOLDFISHING

Shadowbind RNG Ability should work now

Corrected Souleater caculation - Moline Sickle and Ring both need to be equipped for the bonus.