Modified modifier.h

Post Reply
User avatar
Euda
Posts: 43
Joined: Thu Sep 19, 2013 2:36 pm

Modified modifier.h

Post by Euda » Fri Dec 20, 2013 7:06 am

I've modified the modifier.h file to include the following:

-Added (modID #) to end of each modifier. The reason for this was because I was tired of converting hex to dec when adding items to the item_mods.sql. It may be useful for other purposes as well.
-Added comments to modifiers that didn't have comments.

Thanks.
Attachments
modifier.h.patch
(47.88 KiB) Downloaded 348 times
Era Private Server, the best private server I have ever played on ~~ http://ffera.com/ ~~

User avatar
whasf
Site Admin
Posts: 1312
Joined: Thu Jul 19, 2012 9:11 pm

Re: Modified modifier.h

Post by whasf » Sun Dec 22, 2013 1:43 pm

lots of rejected hunks, please update and try again!
-- Whasf

User avatar
Euda
Posts: 43
Joined: Thu Sep 19, 2013 2:36 pm

Re: Modified modifier.h

Post by Euda » Sun Dec 22, 2013 2:49 pm

re-uploaded.
Attachments
modifier.h.patch
(48.45 KiB) Downloaded 336 times
Era Private Server, the best private server I have ever played on ~~ http://ffera.com/ ~~

User avatar
maxtherabbit
Developer
Posts: 57
Joined: Wed Jun 12, 2013 11:26 pm

Re: Modified modifier.h

Post by maxtherabbit » Sun Dec 22, 2013 4:25 pm

still a duplicate modifier problem here, the modifiers MOD_ENMITY_REDUCTION_PHYSICAL (PLD creed gear) and MOD_ADDITIONAL_EFFECT (sirocco kuk, status bolts, etc.) are both assigned to ID 427 and MOD_PERFECT_COUNTER_ATT (MNK tantra gear) and MOD_ENSPELL_DMG_BONUS (enhancing sword) are both assigned to ID 428.

User avatar
Euda
Posts: 43
Joined: Thu Sep 19, 2013 2:36 pm

Re: Modified modifier.h

Post by Euda » Sun Dec 22, 2013 6:52 pm

Those have nothing to do with what I added to the file. Those were pre-existing.
Era Private Server, the best private server I have ever played on ~~ http://ffera.com/ ~~

User avatar
kjLotus
Special Guest
Posts: 1813
Joined: Sun Jul 22, 2012 2:16 pm

Re: Modified modifier.h

Post by kjLotus » Sun Dec 22, 2013 7:38 pm

Euda wrote:Those have nothing to do with what I added to the file. Those were pre-existing.
they're fixed now if you want to merge and re-up

User avatar
maxtherabbit
Developer
Posts: 57
Joined: Wed Jun 12, 2013 11:26 pm

Re: Modified modifier.h

Post by maxtherabbit » Sun Dec 22, 2013 7:58 pm

Euda wrote:Those have nothing to do with what I added to the file. Those were pre-existing.
yeah I didn't mean to imply that you did it, just pointing it out

User avatar
Euda
Posts: 43
Joined: Thu Sep 19, 2013 2:36 pm

Re: Modified modifier.h

Post by Euda » Sun Dec 22, 2013 8:11 pm

Thanks, I'm looking at it now.

Max, I didn't take it personally, I just wanted to say it wasn't something I did. But I'm glad it got fixed.
Era Private Server, the best private server I have ever played on ~~ http://ffera.com/ ~~

User avatar
Euda
Posts: 43
Joined: Thu Sep 19, 2013 2:36 pm

Re: Modified modifier.h

Post by Euda » Sun Dec 22, 2013 8:34 pm

Ok, re-uploaded after the recent changes.

Please let me know if there are any errors.
Attachments
modifier.h.patch
(48.33 KiB) Downloaded 376 times
Era Private Server, the best private server I have ever played on ~~ http://ffera.com/ ~~

Post Reply