Page 1 of 1

Modified modifier.h

Posted: Fri Dec 20, 2013 7:06 am
by Euda
I've modified the modifier.h file to include the following:

-Added (modID #) to end of each modifier. The reason for this was because I was tired of converting hex to dec when adding items to the item_mods.sql. It may be useful for other purposes as well.
-Added comments to modifiers that didn't have comments.

Thanks.

Re: Modified modifier.h

Posted: Sun Dec 22, 2013 1:43 pm
by whasf
lots of rejected hunks, please update and try again!

Re: Modified modifier.h

Posted: Sun Dec 22, 2013 2:49 pm
by Euda
re-uploaded.

Re: Modified modifier.h

Posted: Sun Dec 22, 2013 4:25 pm
by maxtherabbit
still a duplicate modifier problem here, the modifiers MOD_ENMITY_REDUCTION_PHYSICAL (PLD creed gear) and MOD_ADDITIONAL_EFFECT (sirocco kuk, status bolts, etc.) are both assigned to ID 427 and MOD_PERFECT_COUNTER_ATT (MNK tantra gear) and MOD_ENSPELL_DMG_BONUS (enhancing sword) are both assigned to ID 428.

Re: Modified modifier.h

Posted: Sun Dec 22, 2013 6:52 pm
by Euda
Those have nothing to do with what I added to the file. Those were pre-existing.

Re: Modified modifier.h

Posted: Sun Dec 22, 2013 7:38 pm
by kjLotus
Euda wrote:Those have nothing to do with what I added to the file. Those were pre-existing.
they're fixed now if you want to merge and re-up

Re: Modified modifier.h

Posted: Sun Dec 22, 2013 7:58 pm
by maxtherabbit
Euda wrote:Those have nothing to do with what I added to the file. Those were pre-existing.
yeah I didn't mean to imply that you did it, just pointing it out

Re: Modified modifier.h

Posted: Sun Dec 22, 2013 8:11 pm
by Euda
Thanks, I'm looking at it now.

Max, I didn't take it personally, I just wanted to say it wasn't something I did. But I'm glad it got fixed.

Re: Modified modifier.h

Posted: Sun Dec 22, 2013 8:34 pm
by Euda
Ok, re-uploaded after the recent changes.

Please let me know if there are any errors.