Hi all, first time contributor. I was playing Paladin yesterday and I noticed that Shield Mastery wasn't working. Rather than just complaining about it, I decided to try to implement it, so I did!
I've updated modifiers.h and added a new mod, MOD_SHIELD_MASTERY_TP (485), whose value is the bonus TP granted by Shield Mastery.
I've updated traits.sql and modified the entries for Shield Mastery to use the above mod.
I've modified battleutils.cpp to check for Shield Mastery and a shield block before trying to interrupt spells, and to grant bonus TP on a shield block with shield mastery based on the MOD_SHIELD_MASTERY_TP mod value (providing the unblocked damage, i.e. the damage before blocking but after stoneskin/phalanx would be greater than 0).
I look forward to any feedback and to trying it out on the test server!
Shield Mastery
-
Jupiter065
- Posts: 4
- Joined: Wed Apr 30, 2014 10:44 am
Shield Mastery
- Attachments
-
Shield_Mastery_2014-04-30.patch- (9.95 KiB) Downloaded 169 times
Last edited by Jupiter065 on Wed May 07, 2014 11:47 pm, edited 1 time in total.
Re: Shield Mastery
i see you had a pull request and closed it, contributions have to be done via pull request now 
-
Jupiter065
- Posts: 4
- Joined: Wed Apr 30, 2014 10:44 am
Re: Shield Mastery
Ok, I'll do up another one.