Deprecated Darkstar fourms

weaponskill3.7z

changes :
-multi-hit WS will grant 1 extra tp per attacks past first hit
-dual-wielding will grant 1 extra attack that will generate full tp
-physical WS can proc double attack on all hits
-physical WS can proc triple attack on first (+second if dual-wielding) hit (not ranged for both of these)
-added armor down debuff to armor break (the rest will probably come sooner or later)
-removed an unused weaponskill (blake_ku.lua, did nobody notice this? >_>)

internal changes: all weaponskills return 3 variables: tpHits (# of hits that generate full TP), extraHits (# of hits that generate 1 TP), damage

TakePhysicalDamage (battleutils.cpp) isUserTpGain changed to tpMultiplier. Use 1 if previously you would have used true, 0 for false. (changed to let the dual-wield added hit in WS add extra TP)


zanshin.7z

changes:
-autoattacks that missed and that did not already proc multiple hits can proc zanshin
-zanshin proc: extra auto attack with +34 acc
-zanshin works with dual-wield
-zanshin can proc regardless of miss with 1/4 rate as normal zanshin if SAM is main job and hasso is up
-fixed traits.sql for correct ranks and numbers for zanshin

also added a function in battleutils GetHitRateAccOffset, same as GetHitRate except taking into account an accuracy offset

todo: zanshin on WS, zanshin/counter with seigan

Please resubmit based off of rev 1528

whasf wrote:Please resubmit based off of rev 1528

done (for weaponskills, i think you said zanshin was good?)

kjLotus wrote:

whasf wrote:Please resubmit based off of rev 1528

done (for weaponskills, i think you said zanshin was good?)

I had to back both out >.>

whasf wrote:

kjLotus wrote:

whasf wrote:Please resubmit based off of rev 1528

done (for weaponskills, i think you said zanshin was good?)

I had to back both out >.>

ficks incoming

edit: zanshin patches on to 1528 with no errors. it's possible that they conflict with each other however, i didn't develop one off the other so they probably just have to go in one at a time

i can combine them into one if you'd prefer that

edit 2: weaponskills applies no problems on top of zanshin as well

so zanshin should have worked, maybe something went full crazy or something