item_mods update
Posted: Mon Jul 13, 2015 7:23 pm
Hi all,
I was originally planning on going through all the files that legion posted, but looks like most have been integrated, except for item_mods.
There are plenty of people on our server are hoping to have more gear working, so I was going to take on the task of checking and integrating legion's mods into ds core. But I'm noticing a few things in the current item_mods.sql and have a few questions that I would like to run by you before I dump the time into it all.
I'd like to do a cleanup first; remove most of the comments (I plan on leaving the todo/not-added comments in there obviously), and re-order all inserts so that its in order by itemid (which is how I figure it was originally based upon the comment in there, and has just since lost order as things were added but not maintained).
Then I'll add in comments on ALL lines for what the stat modifiers are, like existing comments (ex: --DEF +7) for most of the big/main modifiers. There's alot of modifiers, so they won't all get added at once, but in time (I'll use regex to add comments one modifier at a time). Then I can go about merging legion's ordered stat mods into DS core(ordered). This should make it easy to go through and see exactly what the changes are that were made w/winmerge, and also for myself and a few of the guys on our private server to go through and check all the changes.
There's a few reasons I ask. First is because I know this will probably look like a few super ugly commits, especially with the initial cleanup of the current file (should be an easy check to see if everything is OK with a temp table and a select statement - but I'm pretty confident will look like complete crap in GIT). Also didn't know if you'd be OK with pull requests to update as we're making progress, or if we should wait until its all done, etc.
Mainly just wanted to drop a line and start a conversation about this before the time gets spent. Other main reason I ask is that I know the focus of the project right now is on ToAU and WotG content, and not the newer expansions that this relates to. Once I get through this item_mod update (or checking the rest of legion's files too, if there is any of that that still needs to happen), I do plan on dipping into other parts of the project and working on the current focus.
I was originally planning on going through all the files that legion posted, but looks like most have been integrated, except for item_mods.
There are plenty of people on our server are hoping to have more gear working, so I was going to take on the task of checking and integrating legion's mods into ds core. But I'm noticing a few things in the current item_mods.sql and have a few questions that I would like to run by you before I dump the time into it all.
I'd like to do a cleanup first; remove most of the comments (I plan on leaving the todo/not-added comments in there obviously), and re-order all inserts so that its in order by itemid (which is how I figure it was originally based upon the comment in there, and has just since lost order as things were added but not maintained).
Then I'll add in comments on ALL lines for what the stat modifiers are, like existing comments (ex: --DEF +7) for most of the big/main modifiers. There's alot of modifiers, so they won't all get added at once, but in time (I'll use regex to add comments one modifier at a time). Then I can go about merging legion's ordered stat mods into DS core(ordered). This should make it easy to go through and see exactly what the changes are that were made w/winmerge, and also for myself and a few of the guys on our private server to go through and check all the changes.
There's a few reasons I ask. First is because I know this will probably look like a few super ugly commits, especially with the initial cleanup of the current file (should be an easy check to see if everything is OK with a temp table and a select statement - but I'm pretty confident will look like complete crap in GIT). Also didn't know if you'd be OK with pull requests to update as we're making progress, or if we should wait until its all done, etc.
Mainly just wanted to drop a line and start a conversation about this before the time gets spent. Other main reason I ask is that I know the focus of the project right now is on ToAU and WotG content, and not the newer expansions that this relates to. Once I get through this item_mod update (or checking the rest of legion's files too, if there is any of that that still needs to happen), I do plan on dipping into other parts of the project and working on the current focus.
