Assassin Trait

[ciradan]

The patch should make the assassin trait for thf working.
It should make TA's with correct positioning 100% hits (also changed this for SA requiring you to be behind a mob, prior you got 100% hitrate no matter where you stand)
It should also make the next attack a guaranteed crit when requirements are met.

I have not tested it, as installing all that stuff and making my own server didn't go quite well on this machine, so it would be cool if someone else could check if it works (probably not lol).

I'm trying to get the server running on one of my own machines, but god knows how long that could take.

[whasf]

I'll leave this for link or bluekirby0 to check out

[ciradan]

Alright, so I got around to install everything and test this patch. As expected it didn't work lol.

This one, however, does.
Also it not only "adds" the assassin trait, it also fixes some stuff I came across.

Changelog:
- SA now only gives 100% hitrate when positioned behind the mob (position didn't matter before)
- TA now also works from any mob direction as long as you're behind another player (before you had to be behind a player AND that one had to be behind the mob)
- At level 60+ thfs get 100% critrate and hitrate with TA as long as they're behind a player
- A failed SA now takes crit merits into account
- A missed SA (which is now possible) now takes accuracy stuff into account

What does not work:
- The 100% crit- and hitrate do not trigger during a WS

Frankly, I don't know how to do that.
I guess I'd have to edit the weaponskill.lua for it, no? I looked a bit through it and it shouldn't be all too hard, but I kept my fingers from it because I'm not quite certain if it's only weaponskill.lua or some other stuff as well.

[ciradan]

Here is the updated version of my patch, now including the assassin trait working with WSs.

Would be nice if someone could take a look at it.
Worked fine on my server.

edit: Oh yeah, and I made some changes to the souleaterBonus in the weaponskill.lua that seemed really weird.
Souleater was only applying when either a WS crited AND you have thf main, or when a weaponskill can't crit.
I left the original code about that in and just commented it out, in case I just understood something wrong.

Update: Fixed the AGI bonus being calculated wrong for a WSs that did not crit. Generally made the code I added less bloated.

Update2: fixed a bug where assassin was not applying during a WS and sometimes it was applying even though it shouldn't have. Generally tidied up my code a whole lot.
Sorry for making so many updates on this, it's been a pretty long time since I coded something lol...
This should be the last update though.

[bluekirby0]

I can't reliably test anything until this latest client update is fixed so either someone else will have to take a look or it'll have to wait until the client issues are worked out.

[ciradan]

bump...

[kjLotus]

going to be revising this this week most likely

didn't want to bother with assassin until the positional calculations were updated (as assassin doesn't really matter if TA only works from behind...)

[ciradan]

I took a look at your Assassin stuff, found a few problems:

- TA for WSs is NOT supposed to give 100%, only when you have the Assassin trait
- TA for WSs is supposed to give AGI bonus even when you don't have Assassin (so a non-crited, TA'd WS still gets AGI bonus * ftp * pdif)
- TA and SA are NOT supposed to give 100% hitrate, UNLESS their requirements are met (stand behind party/alliance member, stand behind mob)

[kjLotus]

thanks, i'll look into it sometime in the future

[kjLotus]

- TA for WSs is NOT supposed to give 100%, only when you have the Assassin trait

you accidentally a word, so i'm not sure what you're talking about here