Page 1 of 1

Merits a few WS and a few Magics

Posted: Sun Feb 24, 2013 1:24 am
by compmike19
The stuff in this patch should fix the following merits to work

WHM
Barspell Effect
Banish Effect
Regen Effect
Protectra V
Shellra V

RDM
All Elemental Accuracys
All Merit II & III Spells

BRD
Minne Effect
Minuet Effect
Madrigal Effect

PLD
Cover Effect

BLM
All Elemental Potencys
All Ancient Magic II Spells

NIN
All Elemental Debuff Effects
All Merit San Spells

Also included some missing weapon skills and some missing magic spells.

Re: Merits a few WS and a few Magics

Posted: Sun Feb 24, 2013 2:41 am
by kjLotus
scripts/db look fine

for core, i don't like the method, i would rather it be done any way other than a gigantic if/else
maybe another db column. look at how i did merit abilities for example

Re: Merits a few WS and a few Magics

Posted: Sun Feb 24, 2013 9:35 pm
by kjLotus
function curePotency(caster)

this function isn't needed, this is what MOD_CURE_POTENCY is for

Re: Merits a few WS and a few Magics

Posted: Sun Feb 24, 2013 9:36 pm
by kjLotus
can you split this patch into a few different ones? one for weaponskills, one for merits, etc

Re: Merits a few WS and a few Magics

Posted: Sun Feb 24, 2013 11:29 pm
by compmike19
Weaponskills

Re: Merits a few WS and a few Magics

Posted: Sun Feb 24, 2013 11:33 pm
by compmike19
Missing Magics

Re: Merits a few WS and a few Magics

Posted: Sun Feb 24, 2013 11:44 pm
by compmike19
Merit stuff and Merit related Spells