New Server looking for some help :)

[Delaide]

I myself am trying to learn how to do C++ and lua scripting, since I enjoy this project and would like to see it more fully implemented. I only run a private server, and only use the git code, but I would like to be able to figure it out. However, at this point I am too much of a noob to create any unique code, and still in the beginning stages of learning C++, not sure if I would be able to contribute without someone to hold my hand until I have a better grasp on LUA or C++. But, if you guys are willing to help guide me, I would be willing to try to help.

[compmike19]

Patches were submitted in the past with many of my implementations of non working content. It sat on the board and died there. We still use a lot of the content I had posted in this forum, although updated to reflect core changes from Darkstar or changes I have made. Since it was never "good" enough or worth the developers time to look through I quit updating it and tearing it apart into small chunks to submit patches for. The Gas Giant SVN on google code hosts a substantial portion of code I worked on and now DSP regularly accepts commits from it's maintainer. Basically after someone else starts to submit large chunks of code I worked on it's fine, since I'm not attached to it anymore.

[atom0s]

Patches were submitted in the past with many of my implementations of non working content. It sat on the board and died there. We still use a lot of the content I had posted in this forum, although updated to reflect core changes from Darkstar or changes I have made. Since it was never "good" enough or worth the developers time to look through I quit updating it and tearing it apart into small chunks to submit patches for. The Gas Giant SVN on google code hosts a substantial portion of code I worked on and now DSP regularly accepts commits from it's maintainer. Basically after someone else starts to submit large chunks of code I worked on it's fine, since I'm not attached to it anymore.

The issues with what you submitted where the size and array of things each patch altered. Instead of posting patches for single changes, you combined any and all changes you made into a single huge patch which made testing a pain as every single part of your patch had to be thoroughly tested and if failed, it resulted in the entire patch being useless from 1 thing being broken / bad.

Afterward when you split the files into single chunks, the development team was at the point where it was basically kjLotus and myself doing all the core work / changes. I personally do not have the free time to test every patch submitted / posted so I did not have the time to cover your topic of all your patches. It was nothing ill-willed toward you personally or playing favorites with others, it was simply a matter of who had time to add your patch, test it, then commit it to the real repo all of which takes a bit of time to ensure the patch does not cause issues in other areas of the core.

You are more than welcome to resubmit them on Git using the pull request system, as it is a much easier to handle system and allows us to review the code easier as well as test it faster. Keep in mind though that the core team is only kjLotus at this time so yes there is still going to be delays getting your patches reviewed and commited.

[TeoTwawki]

The Gas Giant SVN on google code hosts a substantial portion of code I worked on and now DSP regularly accepts commits from it's maintainer. Basically after someone else starts to submit large chunks of code I worked on it's fine, since I'm not attached to it anymore.

Mike, this makes it sound as if I regularly commit your code. Apologies if I'm oversensitive about it, but a certain third party has made the claim that every commit I make is stolen code so I feel the need to make sure its clear that when I share code that wasn't mine I do my best to make sure that it is clearly so and credited. I recently re-shared a portion of the item list you did. We were all running into those same problems and most people we both talked to felt that way back when it was all SVN patches but its a lot better now, if you actually want to give it another go at having your stuff in the official trunk.

I've often got the vibe certain content (because too soon for expansion X/Y/Z probably) or customizing settings (not be confused custom content, which is always a big NO) are less welcome, but even that tends to make it in so long as it isn't equivalent to a 1 line change in a script somewhere. I regularly make new stuff on top of the core you shared, and that is most of my commits to both my github branches and the SVN repo.