MeritSystem: Causing game server crash.

[tagban]

https://github.com/DarkstarProject/darkstar/issues/159

Wasn't sure whats going on, seems like the merits when turned in are causing it? And its not for everyone. Might just need a debug check at this point, to check to see if something is wrong, return it? that way it doesn't crash.

[kjLotus]

it's because someone is trying to log in, and their charID is 0 (from the login packet)

[tagban]

So the login server isn't pushing the correct info? It always seems to crash on the Merit Thingy..

[atom0s]

Its an issue with the lobby < > client communication. The exact reason/location is not known at the moment though. Basically the first packet the game client sends to the game server is a login packet (0x0A) which contains your charid that is logging in. DSP has no protection or checks to ensure that the charid is valid.

[tagban]

So its a random crash, so no point in me running debug mode anymore?

[kjLotus]

So its a random crash, so no point in me running debug mode anymore?

i'm just gonna check against charid 0 and be done with it

[tagban]

Had another crash, but not sure if its related or not... So didn't want to make a new bug yet.

http://ffxi.bnet.cc/dumps/DSGame-server-4-22-2.7z

[kjLotus]

Had another crash, but not sure if its related or not... So didn't want to make a new bug yet.

http://ffxi.bnet.cc/dumps/DSGame-server-4-22-2.7z

it's the same one you posted before the charID one.. thought i fixed it :\

[tagban]

Yea I update my scripts (or have it pull and re-build) after every crash just to be on the safe side.. lol I thought you had to.

[kjLotus]

Yea I update my scripts (or have it pull and re-build) after every crash just to be on the safe side.. lol I thought you had to.

ah... it's a GM doing that. if a real character crashes the server, i'll be glad to fix it, but GMs have tons of ways to break the server so i'm not gonna bother trying to figure out what he did

tell kaisho to stop doing stupid things