Lift Auction House Restrictions?

User avatar
fentus
Posts: 4
Joined: Fri Jul 18, 2014 5:49 pm

Lift Auction House Restrictions?

Post by fentus » Tue Oct 07, 2014 2:15 am

Hi I am a bit new to lua and the DSP.

I am looking to remove or adjust the following restrictions on the auction house:
1.) 7 items to infinite
2.) 1 Week duration to infinite
3.) Tax


Any info would be helpful.

I have been looking at the following file:
auction_house.cpp

Thanks!

User avatar
atom0s
Developer
Posts: 537
Joined: Thu Oct 25, 2012 9:52 am

Re: Lift Auction House Restrictions?

Post by atom0s » Tue Oct 07, 2014 5:20 am

Look in: src\map\packets\auction_house.cpp

The slot limit is where you will see all the pieces of code like:
slot > 7
slot < 7

Duration for 1 week, I don't even think works. I don't recall us having expiring items yet as it was something whasf was supposed to finish after I coded part of what he needed. As far as I know its still not implemented so items should not expire if I recall.

Tax is calculated here:
WBUFL(data,(0x08)-4) = 0x00; // AUCTION_FEE(PItem->getCharPrice());

It is currently set to 0 as it was removed on retail.

User avatar
whasf
Site Admin
Posts: 1312
Joined: Thu Jul 19, 2012 9:11 pm

Re: Lift Auction House Restrictions?

Post by whasf » Tue Oct 07, 2014 10:25 am

Expiration is almost done, it'll be implemented in the search server (and configurable). Just having a bit of trouble with the SQL connections..
-- Whasf

User avatar
kjLotus
Special Guest
Posts: 1813
Joined: Sun Jul 22, 2012 2:16 pm

Re: Lift Auction House Restrictions?

Post by kjLotus » Tue Oct 07, 2014 2:55 pm

atom0s wrote:It is currently set to 0 as it was removed on retail.
are you sure you're not thinking of bazaar tax

User avatar
fentus
Posts: 4
Joined: Fri Jul 18, 2014 5:49 pm

Re: Lift Auction House Restrictions?

Post by fentus » Tue Oct 07, 2014 3:07 pm

Thank you very much I figured it was just the '7's I was not sure if there was any issues with that or if anything else had to be changed! (and wow good response time appreciated!)

Dragomair
Posts: 12
Joined: Sun Jun 02, 2013 2:21 am

Re: Lift Auction House Restrictions?

Post by Dragomair » Wed Oct 08, 2014 2:54 am

atom0s wrote:Look in: src\map\packets\auction_house.cpp

The slot limit is where you will see all the pieces of code like:
slot > 7
slot < 7

Duration for 1 week, I don't even think works. I don't recall us having expiring items yet as it was something whasf was supposed to finish after I coded part of what he needed. As far as I know its still not implemented so items should not expire if I recall.

Tax is calculated here:
WBUFL(data,(0x08)-4) = 0x00; // AUCTION_FEE(PItem->getCharPrice());

It is currently set to 0 as it was removed on retail.
Retail AH tax was reduced majorly but it still exists.
Bazaar tax however was removed completely.

User avatar
atom0s
Developer
Posts: 537
Joined: Thu Oct 25, 2012 9:52 am

Re: Lift Auction House Restrictions?

Post by atom0s » Wed Oct 08, 2014 4:39 am

Ah I got them mixed up / reversed.

User avatar
TeoTwawki
Developer
Posts: 527
Joined: Mon Jul 15, 2013 9:50 pm

Re: Lift Auction House Restrictions?

Post by TeoTwawki » Wed Oct 08, 2014 10:08 am

Hmm. Seems any value greater than 7 results in infinity slots, so we can't do something like just make it 10 by just tweaking that number. I suppose it doesn't mater much since the display part client side still won't show more than 7 and locks you out if your try to view sales status after having more than 7 items listed (till you re log out/in). Most folks wanting to change it will prolly prefer infinite anyway.
Hi, I run The Demiurge server.


Image
Always code as if the guy who ends up maintaining your code will be a violent psychopath who knows where you live. - Martin Golding
PLS USE [ code ] CODE TAGS [ /code ] WHEN POSTING CODE
DO NOT PRIVATE MESSAGE ME ABOUT BUGS

User avatar
fentus
Posts: 4
Joined: Fri Jul 18, 2014 5:49 pm

Re: Lift Auction House Restrictions?

Post by fentus » Wed Oct 08, 2014 5:02 pm

I got around to testing this and the client wont let me sell anything past 7 items :C Any ideas?

Edit: Would I need to use a @sell command or something?

User avatar
TeoTwawki
Developer
Posts: 527
Joined: Mon Jul 15, 2013 9:50 pm

Re: Lift Auction House Restrictions?

Post by TeoTwawki » Wed Oct 08, 2014 5:13 pm

fentus wrote:I got around to testing this and the client wont let me sell anything past 7 items :C Any ideas?

Edit: Would I need to use a @sell command or something?
I tested with it at 9, and it worked (and had inf slots). Note there are two spots in the code where its checking that number, and if you open sales menu status the client will enforce its own restriction.
Hi, I run The Demiurge server.


Image
Always code as if the guy who ends up maintaining your code will be a violent psychopath who knows where you live. - Martin Golding
PLS USE [ code ] CODE TAGS [ /code ] WHEN POSTING CODE
DO NOT PRIVATE MESSAGE ME ABOUT BUGS

Post Reply