Code: Select all
Info: patch created from revision 2015.
What does this change:
ATTACK & COMBAT SKILLS
1) Attack Power was calculated with an unique formula for both 1-handed and 2-handed weapons. Now 1-handed weapons have their ATT scaling with STR/2, while 2-handed ones now scales with 3/4STR. (http://wiki.ffxiclopedia.org/wiki/Attack). Moreover attack power now takes into account +skill coming from Gears.
2a) Modified Accuracy formula. Now, as on retail, 1-handed weapons have their accuracy modified by DEX/2, instead 2-handed weapons by 3/4DEX. Moreover accuracy now takes into account +skill coming from Gears.
2b) The new formula fixes a bug too. Now accuracy depends on the skill a character has with the weapon is wielding (so if you have A+ in main-hand and C in off-hand, off-hand will have lower accuracy, exactly like retail). Before this fix off-hand accuracy was equal to the main weapon one.
3) Modified Evasion Formula. Now takes into account +skill coming from Gears.
4) With this Fix all the Character Skills found in the respective Menus will be updated accordingly. (+Skill Gears are fully working from now)
5) The check command now is more retail like. Now It estimates mob evasion and defense. (http://wiki.ffxiclopedia.org/wiki/Check)
6) Modified Evasion Bonus Trait. it was giving Ranged Defence(was set to MOD_RDEF=0x45=69). Now it gives evasion+ (MOD_EVA=0x44=68).
---
Shield, Guarding and Parry where already working.
---
Most of the "Magical" Skills are already working. They are calculated correctly into the ".lua" spell files //
I found some spells that where missing the +skill mods from their maths and fixed them. If I should find other spells not calculating the +skill (or if anybody should make a report about it), I will submit the proper fix.
---
This does not modify Crafting +Skills. They should still be broken. (Since I haven't crafted much on retail I still don't know some mechanics. Fixing +Craft Skills may modify the way "Craft Difficulties" is calculated and therefore the "skillups rate").
PS:
From now on use GetSkill(SkillID) to get Char base Skill, GetTotalSkill(SkillID) to get the "base Skill + Mods".Code: Select all
enchanceSkill = caster:getSkillLevel(34) + caster:getMod(79 + 34);
Code: Select all
enchanceSkill = caster:getSkillLevel(34) + caster:getMod(MOD_ENHANCE);
