isWeaponSkillKill crashing map-server

Bug reports go here: https://github.com/DarkstarProject/darkstar/issues

Just talk about them here please.
Forum rules
POST BUG REPORTS HERE: https://github.com/DarkstarProject/darkstar/issues

Try to keep the noise down on the reports on github, emails go out for every post on a bug report. :-)
Post Reply
rezza
Posts: 11
Joined: Fri May 10, 2013 10:24 am

isWeaponSkillKill crashing map-server

Post by rezza » Mon Jun 03, 2013 10:01 pm

Folks,

This one is a real head scratcher for us. We're working with a fresh pull from source, clean project builds, fresh new shiny builds, fresh shiny new DB. We've made only the bare minimum changes to config files to make the servers run, in the hopes of ruling out errors on my part. There's no real getting around the fact that this is a giant problem for us. Anytime a kill is made with a summoner bloodpact (we've been repro'ing mostly with Rush, Predator Claws, and Chaotic Strike) the game server crashes. Upon debug, it goes to this section of code here, and I just do not know what its trying to do, presumable evaluate if a weaponskill was used for the kill for some reason:

void CCharEntity::setWeaponSkillKill(bool isWeaponSkillKill)
{
m_isWeaponSkillKill = isWeaponSkillKill;
}

This also happens anytime a BLU spell is used to kill a mob. Frenetic Rip, Cannonball, and something else, can't recall what (i was never a BLU) make this happen as well.
[edit] EagleEye Shot also produces this crash on a kill.

We're retesting now, the original report from my guys on this was from a NIN WS kill. I'm having them get me the exact name. We're running r3458, fresh shiny new pull/build.

Obviously, the game isn't really playable if all these events just flat out crash the server. We'd really appreciate any feedback or help tracking this one down.

megazraff
Posts: 12
Joined: Thu May 16, 2013 11:16 pm

Re: isWeaponSkillKill crashing map-server

Post by megazraff » Tue Jun 04, 2013 1:19 am

Been having similar issues lately. So far Leviathan's water IV and Shiva's Blizzard IV spells insta-crashed the gameserver upon use. Didn't even get as far as showing the animation, just using either skill so far was enough to shut it all down. Haven't had time to test all of the avatars skills just yet but so far I know Ramuh and Ifrit work fine, and half of Titan's abilities have been tested. This build is pretty fresh so not much has been done to it either. If anyone has any ideas that might help I'd greatly appreciate it.

rezza
Posts: 11
Joined: Fri May 10, 2013 10:24 am

Re: isWeaponSkillKill crashing map-server

Post by rezza » Tue Jun 04, 2013 1:39 am

As suggested, we rebuilt fresh again.

Repro'd, r3460 since that's what came down from Trunk on checkout.

Steps:
-deleted all project dsp material, ensured nothing opened in visual studio
-rebooted the server
-checked out from google code to suggested default onetimexi folder, got r3460
-edited .conf files to have correct db connection info
-opened all 3 server apps in visual studio one by one, clean solution, build solution
-launched all 3 server apps with admin rights
-connected with client, was still in eastern altepa from previous test
-ran to nearest dhalmel mob, summoned shiva, used rush
-killed mob, map server crashes immediately with same error and behavior presentation
-debugged, captured crash dump, attached to existing bug report

rezza
Posts: 11
Joined: Fri May 10, 2013 10:24 am

Re: isWeaponSkillKill crashing map-server

Post by rezza » Wed Jun 05, 2013 11:00 pm

Thank you, thank you, THANK YOU for r3464. Resolved this- I tested every skill we had noted produced this crash previously, and we saw no hiccups or problems.
:D :D

megazraff
Posts: 12
Joined: Thu May 16, 2013 11:16 pm

Re: isWeaponSkillKill crashing map-server

Post by megazraff » Thu Jun 13, 2013 6:12 pm

Updated through 3480 and still having same issues with Shiva/Leviathan crashing server using tier 4 magics

bluekirby0
Developer
Posts: 707
Joined: Sun Jul 22, 2012 12:11 am

Re: isWeaponSkillKill crashing map-server

Post by bluekirby0 » Thu Jun 13, 2013 6:26 pm

That is probably a different bug since it is caused by a smaller skill set.

Post Reply