the age old SmallPacket0x017 errors

Bug reports go here: https://github.com/DarkstarProject/darkstar/issues

Just talk about them here please.
Forum rules
POST BUG REPORTS HERE: https://github.com/DarkstarProject/darkstar/issues

Try to keep the noise down on the reports on github, emails go out for every post on a bug report. :-)
Post Reply
User avatar
TeoTwawki
Developer
Posts: 516
Joined: Mon Jul 15, 2013 9:50 pm
Contact:

the age old SmallPacket0x017 errors

Post by TeoTwawki » Tue Sep 27, 2016 7:58 pm

Code: Select all

void SmallPacket0x017(map_session_data_t* session, CCharEntity* PChar, CBasicPacket data)
{
    uint16 targid = RBUFW(data, (0x04));
    uint32 npcid = RBUFL(data, (0x08));
    uint8  type = RBUFB(data, (0x12));

    ShowError(CL_RED"SmallPacket0x17: Incorrect NPC(%u,%u) type(%u)\n" CL_RESET, targid, npcid, type);
    return;
}
That error has been showing for a long time but there appear to be zero related negative effects in game.

I've asked about it before on IRC when I was curious about the reason for it triggering. But now I am wondering what the purpose even is. Since there doesn't seem to be a downside to ignoring it, maybe it should be a ShowWarning instead of ShowError? There's not much point to stuffing the console log full of that message every day if the server operator only wants serious error messages and nobody is fixing the error anytime soon.
Hi, I run The Demiurge server.

Code: Select all

PLS USE [code]CODE TAGS[/code] WHEN POSTING CODE
Image
Always code as if the guy who ends up maintaining your code will be a violent psychopath who knows where you live. - Martin Golding
DO NOT PRIVATE MESSAGE ME ABOUT BUGS

User avatar
kjLotus
Lead Developer
Posts: 1813
Joined: Sun Jul 22, 2012 2:16 pm

Re: the age old SmallPacket0x017 errors

Post by kjLotus » Tue Sep 27, 2016 9:16 pm

what targid is it for? it shows up when the client rejects a 0x0E because there is something wrong with it

User avatar
demolish
Developer
Posts: 262
Joined: Thu Jul 26, 2012 7:12 am

Re: the age old SmallPacket0x017 errors

Post by demolish » Wed Sep 28, 2016 1:18 am

happens when npc ids shift iirc, mainly in cutscene npc requests
<Giblet[NewBrain]> kj with this first step would be fine on my shit
Click here for a guide on scripting missions.

User avatar
TeoTwawki
Developer
Posts: 516
Joined: Mon Jul 15, 2013 9:50 pm
Contact:

Re: the age old SmallPacket0x017 errors

Post by TeoTwawki » Wed Sep 28, 2016 10:50 am

The IDs showing in this message seem to be all players form what I see, not actual NPCs.

[28/Sep] [12:46:59][Error] SmallPacket0x17: Incorrect NPC(1026,28581) type(4)
[28/Sep] [12:47:05][Error] SmallPacket0x17: Incorrect NPC(1025,26091) type(4)
[28/Sep] [12:48:38][Error] SmallPacket0x17: Incorrect NPC(1029,29065) type(4)
Hi, I run The Demiurge server.

Code: Select all

PLS USE [code]CODE TAGS[/code] WHEN POSTING CODE
Image
Always code as if the guy who ends up maintaining your code will be a violent psychopath who knows where you live. - Martin Golding
DO NOT PRIVATE MESSAGE ME ABOUT BUGS

User avatar
kjLotus
Lead Developer
Posts: 1813
Joined: Sun Jul 22, 2012 2:16 pm

Re: the age old SmallPacket0x017 errors

Post by kjLotus » Wed Sep 28, 2016 7:43 pm

yeah - when that happens, the client who reported it will not be able to see a player they should have been able to see

I think it started with the ai rewrite, but I haven't looked into it much yet

User avatar
TeoTwawki
Developer
Posts: 516
Joined: Mon Jul 15, 2013 9:50 pm
Contact:

Re: the age old SmallPacket0x017 errors

Post by TeoTwawki » Wed Sep 28, 2016 10:54 pm

I've been seeing floods of that message since before the project moved to github but it has seemed worse lately. Never really cared back then because my own server was puny so it wasn't that much of a problem. Been on a log cleaning spree lately because whenever anyone asks for my help the first thing I do is read their console log for whatever obvious thing they missed :)
Hi, I run The Demiurge server.

Code: Select all

PLS USE [code]CODE TAGS[/code] WHEN POSTING CODE
Image
Always code as if the guy who ends up maintaining your code will be a violent psychopath who knows where you live. - Martin Golding
DO NOT PRIVATE MESSAGE ME ABOUT BUGS

Post Reply