Where Are Spell Flags stored?

Bug reports go here: https://github.com/DarkstarProject/darkstar/issues

Just talk about them here please.
Forum rules
POST BUG REPORTS HERE: https://github.com/DarkstarProject/darkstar/issues

Try to keep the noise down on the reports on github, emails go out for every post on a bug report. :-)
Post Reply
cszark
Posts: 8
Joined: Wed Feb 22, 2017 9:10 pm

Where Are Spell Flags stored?

Post by cszark » Sat Feb 25, 2017 2:33 pm

Hi,

I am looking for help to identify where spell flags are stored. I know SQL very well, but for the life of me, I can't figure out what sets these values.

I couldn't find an existing bug report and would like to simply understand this.

darkstar/src/map/spell.h
enum SPELLFLAG
{
SPELLFLAG_NONE = 0x00,
SPELLFLAG_HIT_ALL = 0x01, // Hit all targets in range regardless of party
SPELLFLAG_WIPE_SHADOWS = 0x02 // Wipe shadows even if single target and miss/resist (example: Maiden's Virelai)
};

I am trying to identify why so many spells that are cast have a spellflag value of 0x02, where they shouldn't be and correct this either in a database or the code.
Here are some examples with a spellflag value of 0x02:
Aero III
Bind
Burst
Flare
Drain
Drown
Poision II
Quake
Sleep II
Tornado

Here are some examples with a spellflag value of 0x00: (working a expected)
Bio III
Blind
Burn
Choke
Flood
Fire III
Freeze
Frost
Stun

The code I am debugging is:
darkstar/src/map/entities/battleentity.cpp ~line 1215 (take all shadows)

I added a bit of code in my environment to help debug and display the spellflag values, so I know which spells are doing what.
I have been specifically testing against tonberry_maledictor mobs.

User avatar
TeoTwawki
Developer
Posts: 516
Joined: Mon Jul 15, 2013 9:50 pm
Contact:

Re: Where Are Spell Flags stored?

Post by TeoTwawki » Sun Feb 26, 2017 4:39 am

not stored, set in script and checked for in core
https://github.com/DarkstarProject/dark ... &type=Code
https://github.com/DarkstarProject/dark ... PE_SHADOWS

you have something wrong because we have only one thing in the entire trunk using that flag right now
Hi, I run The Demiurge server.

Code: Select all

PLS USE [code]CODE TAGS[/code] WHEN POSTING CODE
Image
Always code as if the guy who ends up maintaining your code will be a violent psychopath who knows where you live. - Martin Golding
DO NOT PRIVATE MESSAGE ME ABOUT BUGS

cszark
Posts: 8
Joined: Wed Feb 22, 2017 9:10 pm

Re: Where Are Spell Flags stored?

Post by cszark » Sun Feb 26, 2017 12:16 pm

Thank you for confirming. I thought it was for just that one spell. I am going to gather some additional data and open a bug report if I am still having problems. This is a fun project. Thanks!

Post Reply